Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the if check #2859

Merged
merged 1 commit into from
Nov 22, 2024
Merged

ci: fix the if check #2859

merged 1 commit into from
Nov 22, 2024

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Nov 22, 2024

What problem does this PR solve?:
if check in apptests generate upgrade version step is wrong

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Nov 22, 2024
@cwyl02 cwyl02 requested a review from a team November 22, 2024 19:45
@cwyl02 cwyl02 self-assigned this Nov 22, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11979109336

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 11976917142: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@cwyl02 cwyl02 merged commit 41e05ab into main Nov 22, 2024
48 checks passed
@cwyl02 cwyl02 deleted the ychen/fix-apptest-genver branch November 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants