Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Adjust the release automation to handle ghcr #2852

Merged
merged 1 commit into from
Nov 21, 2024
Merged

build: Adjust the release automation to handle ghcr #2852

merged 1 commit into from
Nov 21, 2024

Conversation

mikolajb
Copy link
Contributor

What problem does this PR solve?:
The release automation has to be adjusted too:
199536d#diff-320fd277251bdefe63fc147281f3cec45d88932c9e31bfcf17f8658b2ad03e97R1

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Nov 21, 2024
@mikolajb mikolajb requested a review from a team November 21, 2024 16:24
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@mikolajb mikolajb enabled auto-merge (squash) November 21, 2024 16:24
@mikolajb mikolajb force-pushed the mikolajb/adjust-release-automation-ghcr branch from 0b7c210 to 3518885 Compare November 21, 2024 16:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11957473423

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 11956350814: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@mikolajb mikolajb merged commit 1893b8e into main Nov 21, 2024
18 checks passed
@mikolajb mikolajb deleted the mikolajb/adjust-release-automation-ghcr branch November 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

Assignees

@mikolajb mikolajb

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikolajb @coveralls @takirala