Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove hardcoded image in for ai-navigator-cluster-info-agent #2831

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: Remove hardcoded image in for ai-navigator-cluster-info-agent #2831

merged 1 commit into from
Nov 21, 2024

Conversation

alembiewski
Copy link
Contributor

What problem does this PR solve?:
Removes the hardcoded tag and use the default chart value, so we don't have to maintain that in both places.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@alembiewski alembiewski requested review from lukeogg and a team November 20, 2024 09:56
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/ai-navigator-cluster-info-agent labels Nov 20, 2024
@alembiewski alembiewski changed the title fix: Remove hardcoded image tag for ai-navigator-cluster-info-agent fix: Remove hardcoded image in for ai-navigator-cluster-info-agent Nov 20, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Nov 20, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11930956141

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 11930191101: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@alembiewski alembiewski enabled auto-merge (squash) November 21, 2024 00:28
@alembiewski alembiewski merged commit 30d0087 into main Nov 21, 2024
82 checks passed
@alembiewski alembiewski deleted the remove-ain-agent-default branch November 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiwalyajoshi kaiwalyajoshi kaiwalyajoshi approved these changes

@lukeogg lukeogg Awaiting requested review from lukeogg

Assignees
No one assigned
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/ai-navigator-cluster-info-agent size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alembiewski @coveralls @kaiwalyajoshi @mesosphere-ci