Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: s/lastAppliedRevision/lastAttemptedRevision/ after flux bump #2829

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: s/lastAppliedRevision/lastAttemptedRevision/ after flux bump #2829

merged 1 commit into from
Nov 19, 2024

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Nov 19, 2024 •
edited
Loading

What problem does this PR solve?:

https://jira.nutanix.com/browse/NCN-104081

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@takirala takirala self-assigned this Nov 19, 2024
@takirala takirala added ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Nov 19, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/rook-ceph-cluster labels Nov 19, 2024
@mesosphere-ci mesosphere-ci added do-not-merge/testing Do not merge because there is still on-going testing update-licenses signals mergebot to update licenses.d2iq.yaml labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/takirala-patch-1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11917955283

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 11908727076: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@takirala
Copy link
Contributor Author

CI passed with flying colors here https://github.com/mesosphere/kommander/pull/5295

@takirala takirala merged commit b1e2df6 into main Nov 19, 2024
88 of 90 checks passed
@takirala takirala deleted the takirala-patch-1 branch November 19, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwyl02 cwyl02 cwyl02 approved these changes

@mikolajb mikolajb mikolajb approved these changes

Assignees

@takirala takirala

Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/rook-ceph-cluster size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takirala @coveralls @mikolajb @cwyl02 @mesosphere-ci