Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send slack notifications on success and failure #2814

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: send slack notifications on success and failure #2814

merged 1 commit into from
Nov 8, 2024

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Nov 8, 2024 •
edited
Loading

What problem does this PR solve?:

Triggers slack notifications when release is failed as well as successful (for non -dev releases)

Which issue(s) does this PR fix?:

jira.nutanix.com/browse/NCN-103687

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11736868413

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 11721596931: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

msdolbey
msdolbey approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
slackin

@takirala takirala merged commit 38c66e3 into main Nov 8, 2024
19 checks passed
@takirala takirala deleted the tga/send-slack-notification branch November 8, 2024 21:06
@takirala takirala mentioned this pull request Nov 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwyl02 cwyl02 cwyl02 approved these changes

@msdolbey msdolbey msdolbey approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takirala @coveralls @msdolbey @cwyl02