Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): Use grafana 9.5.7 #1496

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Aug 17, 2023

What problem does this PR solve?:
We were overriding the grafana image to avoid this upstream bug grafana/grafana#56087 but it has been fixed so using the latest / default image now -- latest image v10 appears to be breaking prometheus scraping of grafana metrics, pinning to latest 9.5 version for now.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Aug 17, 2023
@gracedo gracedo self-assigned this Aug 17, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/grafana-logging services/project-grafana-logging labels Aug 17, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo marked this pull request as ready for review August 17, 2023 00:41
@coveralls
Copy link

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5895276010

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 5892784839: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@github-actions github-actions bot added services/kube-prometheus-stack size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2023
@gracedo gracedo changed the title feat(grafana-logging): Use default latest grafana image tag feat(grafana): Use more recent grafana image Aug 17, 2023
@gracedo gracedo force-pushed the gracedo/grafana_rm_img_override branch from 9037169 to 3c77429 Compare August 17, 2023 19:47
@gracedo gracedo force-pushed the gracedo/grafana_rm_img_override branch from 3c77429 to bbef0ec Compare August 17, 2023 19:48
@gracedo gracedo changed the title feat(grafana): Use more recent grafana image feat(grafana): Use grafana 9.5.7 Aug 17, 2023
@gracedo gracedo enabled auto-merge (squash) August 17, 2023 23:41
@gracedo gracedo merged commit d5ba90d into main Aug 18, 2023
15 checks passed
@gracedo gracedo deleted the gracedo/grafana_rm_img_override branch August 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/grafana-logging services/kube-prometheus-stack services/project-grafana-logging size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants