fix: not skipping authz for kube dashboard (2.5) #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* fix: should not skip authz for any path see TFA Code about this config option: https://github.com/mesosphere/ traefik-forward-auth/blob/master/internal/handlers/server.go#L497-L504 had to break the URL to 2 lines thanks to pre-commit ;) * fix: bring back kiali skip authz (cherry picked from commit 78c47b3)
2 tasks
cwyl02
added
ready-for-review
ok-to-test
cwyl02
approved these changes
Aug 15, 2023
gracedo
changed the title
gracedo
approved these changes
Aug 15, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
added a commit
that referenced
this pull request
Aug 18, 2023
fix: not skipping authz for kube dashboard (#1462) * fix: should not skip authz for any path see TFA Code about this config option: https://github.com/mesosphere/ traefik-forward-auth/blob/master/internal/handlers/server.go#L497-L504 had to break the URL to 2 lines thanks to pre-commit ;) * fix: bring back kiali skip authz (cherry picked from commit 78c47b3) Co-authored-by: Weiyanli Chen(York) <[email protected]> (cherry picked from commit a47459c)
cwyl02
pushed a commit
that referenced
this pull request
Aug 18, 2023
fix: not skipping authz for kube dashboard (#1462) * fix: should not skip authz for any path see TFA Code about this config option: https://github.com/mesosphere/ traefik-forward-auth/blob/master/internal/handlers/server.go#L497-L504 had to break the URL to 2 lines thanks to pre-commit ;) * fix: bring back kiali skip authz (cherry picked from commit 78c47b3) Co-authored-by: Weiyanli Chen(York) <[email protected]> (cherry picked from commit a47459c)
cwyl02
pushed a commit
that referenced
this pull request
Aug 18, 2023
fix: not skipping authz for kube dashboard (2.5) (#1486) fix: not skipping authz for kube dashboard (#1462) * fix: should not skip authz for any path see TFA Code about this config option: https://github.com/mesosphere/ traefik-forward-auth/blob/master/internal/handlers/server.go#L497-L504 had to break the URL to 2 lines thanks to pre-commit ;) * fix: bring back kiali skip authz (cherry picked from commit 78c47b3) Co-authored-by: Weiyanli Chen(York) <[email protected]> (cherry picked from commit a47459c) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease-2.5:Questions ?
Please refer to the Backport tool documentation