Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove postRenderer from Loki HelmRelease (2.5) #1466

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

cbuto
Copy link
Contributor

@cbuto cbuto commented Aug 7, 2023

What problem does this PR solve?:
The fix for the missing annotations was included in 0.69.4 so we can remove these post render patches now

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cbuto cbuto added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Aug 7, 2023
@cbuto cbuto self-assigned this Aug 7, 2023
@cbuto cbuto added the open-kommander-pr Automatically triggers the creation of a PR in Kommander repo label Aug 7, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/release-2.5/cbuto/loki-reloader-annotations

@cbuto cbuto marked this pull request as ready for review August 7, 2023 18:35
@cbuto cbuto changed the title fix: remove postRenderer from Loki HelmRelease fix: remove postRenderer from Loki HelmRelease (2.5) Aug 7, 2023
@cbuto cbuto requested a review from a team August 7, 2023 18:38
@cbuto cbuto added do-not-merge/testing Do not merge because there is still on-going testing backport-pr This is a backport PR labels Aug 7, 2023
@cbuto
Copy link
Contributor Author

cbuto commented Aug 10, 2023

https://github.com/mesosphere/kommander/pull/3704 is related to this change since i had to bump the loki versions

@cbuto cbuto merged commit b522920 into release-2.5 Aug 10, 2023
38 checks passed
@cbuto cbuto deleted the cbuto/loki-reloader-annotations branch August 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-pr This is a backport PR do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants