Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use https for Insights Engine Helm Mirror URL #1463

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kaiwalyajoshi
Copy link
Contributor

What problem does this PR solve?:

Use https for the helmMirrorURL of the optional Insights Engine component.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@kaiwalyajoshi kaiwalyajoshi added ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review labels Aug 4, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5767186631

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 5766413609: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@kaiwalyajoshi
Copy link
Contributor Author

@d2iq-mergebot backport release-2.6

@kaiwalyajoshi
Copy link
Contributor Author

@d2iq-mergebot backport release-2.5

@kaiwalyajoshi
Copy link
Contributor Author

@d2iq-mergebot backport release-2.4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

💚 All backports created successfully

Status Branch Result
release-2.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Aug 7, 2023
gracedo pushed a commit that referenced this pull request Aug 21, 2023
fix: Use https for Insights Engine Helm Mirror URL (#1463)

(cherry picked from commit d5e933e)

Co-authored-by: Kaiwalya R Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.6 ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants