Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle upgrade to logging-operator v4.2.0 #1459

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

cbuto
Copy link
Contributor

@cbuto cbuto commented Aug 3, 2023

What problem does this PR solve?:
In the logging-operator 4.2.0, the fluent-bit daemonset spec.selector field was updated which is an immutable field.

On upgrade to 2.6, the fluent-bit daemonset is never upgraded because the logging-operator cannot update the DS with the new selectors. The only way to continue is to delete the DS. Unfortunately, since our logging-operator HR is not behind a Kustomization, we don't have a good way of running a job after the operator finishes upgrading so we can't just simply run a kubectl delete on the DS.

By setting enableRecreateWorkloadOnImmutableFieldChange, we allow the operator to recreate resources if required. If this is set, it's recommended to set logging.spec.fluentbit.spec.positiondb and a PVC for the fluentd buffer, both of which we have set.

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-98592

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cbuto cbuto added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Aug 3, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@cbuto cbuto self-assigned this Aug 3, 2023
@cbuto cbuto marked this pull request as ready for review August 3, 2023 19:55
@cbuto cbuto merged commit ebb3b2d into release-2.6 Aug 3, 2023
22 checks passed
@cbuto cbuto deleted the cbuto/logging-op-upgrade branch August 3, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants