-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use prev k8s version for upgrade e2e test #1435
Conversation
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 5741220016
💛 - Coveralls |
62e8c41
to
fd3b42f
Compare
This is a tricky one because we do actually still install kommander on previous kubernetes version before kube version upgrade. That is the supported upgrade process afaik. We should probably test upgrading from both previous k8s version, and current version. Wdyt @gracedo? |
Hmm, you're right that it would be more accurate to use the previous k8s version for the upgrade test, because k-apps are upgraded first before upgrading k8s (at least for now). Although the main focus of the test here is to test the application upgrades (not too much focus on k8s version) we might as well mimic the actual upgrade scenario since it is easy to here. Install tests will still happen on current k8s version, upgrade tests will happen on previous k8s version. |
fd3b42f
to
37cb025
Compare
I believe it's already been seen that current version gatekeeper is not compatible with 1.27 so the tests may fail -- will revert the last commit (trying out 1.27) if I see the same. Will let https://d2iq.atlassian.net/browse/D2IQ-98552 take care of the bump |
4aa357f
to
549c698
Compare
549c698
to
6d170de
Compare
6d170de
to
5b82503
Compare
What problem does this PR solve?:
Made the change to use the same k8s version for upgrade tests since the previous version is compatible on 1.26
Held off on updating to 1.27 because it looks like there were issues with getting that build working in CI
depends on #1455
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist