Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use prev k8s version for upgrade e2e test #1435

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Jul 28, 2023

What problem does this PR solve?:
Made the change to use the same k8s version for upgrade tests since the previous version is compatible on 1.26

Held off on updating to 1.27 because it looks like there were issues with getting that build working in CI

depends on #1455

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Jul 28, 2023
@gracedo gracedo self-assigned this Jul 28, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Jul 28, 2023

Pull Request Test Coverage Report for Build 5741220016

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 5740918391: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@gracedo gracedo changed the title ci: Bump k8s version in e2e tests ci: Bump k8s to 1.27 in e2e tests Jul 28, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2023
@gracedo gracedo changed the title ci: Bump k8s to 1.27 in e2e tests ci: Use same k8s version for upgrade e2e test Jul 28, 2023
@gracedo gracedo marked this pull request as ready for review July 28, 2023 21:47
@gracedo gracedo requested a review from a team July 28, 2023 21:47
@jimmidyson
Copy link
Contributor

This is a tricky one because we do actually still install kommander on previous kubernetes version before kube version upgrade. That is the supported upgrade process afaik. We should probably test upgrading from both previous k8s version, and current version. Wdyt @gracedo?

@gracedo
Copy link
Contributor Author

gracedo commented Aug 1, 2023

This is a tricky one because we do actually still install kommander on previous kubernetes version before kube version upgrade. That is the supported upgrade process afaik. We should probably test upgrading from both previous k8s version, and current version. Wdyt @gracedo?

Hmm, you're right that it would be more accurate to use the previous k8s version for the upgrade test, because k-apps are upgraded first before upgrading k8s (at least for now). Although the main focus of the test here is to test the application upgrades (not too much focus on k8s version) we might as well mimic the actual upgrade scenario since it is easy to here. Install tests will still happen on current k8s version, upgrade tests will happen on previous k8s version.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@gracedo gracedo added the let-me-merge-it Allow author of PR to merge it label Aug 1, 2023
@gracedo
Copy link
Contributor Author

gracedo commented Aug 1, 2023

I believe it's already been seen that current version gatekeeper is not compatible with 1.27 so the tests may fail -- will revert the last commit (trying out 1.27) if I see the same. Will let https://d2iq.atlassian.net/browse/D2IQ-98552 take care of the bump

@gracedo gracedo changed the title ci: Use same k8s version for upgrade e2e test ci: Use prev k8s version for upgrade e2e test Aug 1, 2023
@gracedo gracedo changed the base branch from main to gracedo/gk_3121_bump August 1, 2023 23:59
Base automatically changed from gracedo/gk_3121_bump to main August 2, 2023 15:41
@gracedo gracedo enabled auto-merge (squash) August 2, 2023 16:12
@gracedo gracedo removed the let-me-merge-it Allow author of PR to merge it label Aug 2, 2023
@gracedo gracedo merged commit 03a9f03 into main Aug 2, 2023
11 checks passed
@gracedo gracedo deleted the gracedo/bump_k8s_tests branch August 2, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/gatekeeper size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants