Skip to content

Commit

Permalink
🐛 increase the timeout when creating and upgrading CAPI controllers (#27
Browse files Browse the repository at this point in the history
)

* fix: extend the CAPI warmup timeout

When starting up CAPI will try to "warm-up" the configured RuntimeExtensions,
and fail if any runtime extension Pods are not up.

* fix: extend the clusterctl timeout

This should fix the race conditions seen when creating and upgrading CAPI providers.
  • Loading branch information
dkoshkin committed Oct 9, 2024
1 parent 6754da8 commit 54b068a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cmd/clusterctl/client/cluster/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,13 @@ func retryWithExponentialBackoff(ctx context.Context, opts wait.Backoff, operati

// newWriteBackoff creates a new API Machinery backoff parameter set suitable for use with clusterctl write operations.
func newWriteBackoff() wait.Backoff {
// Return a exponential backoff configuration which returns durations for a total time of ~40s.
// Example: 0, .5s, 1.2s, 2.3s, 4s, 6s, 10s, 16s, 24s, 37s
// Return a exponential backoff configuration which returns durations for a total time of ~6m.
// Example: 0, .5s, 1.2s, 2.3s, 4s, 6s, 10s, 16s, 24s, 37s, 56s, 84s, 126s, 190s
// Jitter is added as a random fraction of the duration multiplied by the jitter factor.
return wait.Backoff{
Duration: 500 * time.Millisecond,
Factor: 1.5,
Steps: 10,
Steps: 14,
Jitter: 0.4,
}
}
Expand Down
2 changes: 1 addition & 1 deletion exp/runtime/internal/controllers/warmup.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (
)

const (
defaultWarmupTimeout = 60 * time.Second
defaultWarmupTimeout = 5 * time.Minute
defaultWarmupInterval = 2 * time.Second
)

Expand Down

0 comments on commit 54b068a

Please sign in to comment.