Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further changes to make ES 5.0 work #597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nubunto
Copy link
Contributor

@nubunto nubunto commented Dec 14, 2016

  • Removed the ES_HEAP_SIZE env var entirely, since ES 5.0 shuts it all
    down if it finds it.
  • Removed the args that are passed to ES, since he doesn't appear to
    accept them anymore. Apparently they have to be given via
    elasticsearch.yml.
  • Updated the way ES_JAVA_OPTS environment variable is set, as opposed
    to ES_HEAP_SIZE. The format is -Xms[MEM][m|g] -Xmx[MEM][m|g].

- Removed the ES_HEAP_SIZE env var *entirely*, since ES 5.0 shuts it all
down if it finds it.
- Removed the args that are passed to ES, since he doesn't appear to
accept them anymore. Apparently they have to be given via
elasticsearch.yml.
- Updated the way ES_JAVA_OPTS environment variable is set, as opposed
to ES_HEAP_SIZE. The format is -Xms[MEM][m|g] -Xmx[MEM][m|g].
@containersol
Copy link
Collaborator

Can one of the admins verify this patch?

@nubunto nubunto mentioned this pull request Dec 14, 2016
@nubunto
Copy link
Contributor Author

nubunto commented Dec 14, 2016

To see the state of these changes, see #594

@frankscholten
Copy link
Contributor

@nubunto After merge conflicts have been resolved, is this one WIP or ready to be merged?

@nubunto
Copy link
Contributor Author

nubunto commented Dec 19, 2016

@frankscholten I believe further polishing might be needed, e.g. I hardcoded megabytes as the ram size, we should improve this.
Also, we need to document a way to pass arguments as we did before. Probably piping a elasticsearch.yml file.
After that, then we should be good, I think.

@frankscholten
Copy link
Contributor

Ok. Can you fix the above conflicts?

@mangolas
Copy link

What is the current situation on running ES5 from Mesos Elasticsearch, should it work after this PR is in?

@ror6ax
Copy link

ror6ax commented Mar 30, 2017

Hi guys, what is the status? Will you agree to merge when conflicts are resolved?

@sadok-f
Copy link

sadok-f commented Jul 27, 2017

Any update about this PR?

@ror6ax
Copy link

ror6ax commented Jul 27, 2017

@containersol @nubunto - guys, can we please get the update on this?

@nubunto
Copy link
Contributor Author

nubunto commented Aug 25, 2017

Hey guys.
I have stepped away from this for a long time. This was actually a work I needed done a year ago (sort of) but we ended up staying away from ES 5 at the time.

I am really far away from this at the moment, and I really don't have the time to maintain this PR or any work that derives from it.
I would recommend that people took a look at this branch (and the last commit I made) and wage through the issues with a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants