Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapdb server static v1 api mirror and nginx config update #1772

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tp-m
Copy link
Member

@tp-m tp-m commented Nov 4, 2024

See #1768 for background.

Content of this MR is basically from https://github.com/tp-m/wrapdb-v1-api-mirror/, seems better to have it right here in the repo next to the nginx config.

Closes #1768

@eli-schwartz
Copy link
Member

I'd prefer to avoid having all these files directly checked into git, though. e.g. we use GitHub Releases to store the ZIP files for all current releases because checking them into git tends to be rather suboptimal usage of git's object storage design.

@tp-m
Copy link
Member Author

tp-m commented Nov 4, 2024

Understood, but I'm just trying to document what's deployed right now on the server, so that it's easily possible to replicate the setup on a new machine if ever needed.

The size of the .zip files here is 977kB and that will not change going forward, since the v1 archive is frozen now.

If someone wants to make sure that all v1 zips (incl. sqlite) are available on github, so we can add redirects for them a la this be my guest.

In the meantime I'm just documenting what's what, and seeing the fairly small size I don't think it's worth worrying about too much.

@bgilbert
Copy link
Contributor

bgilbert commented Nov 4, 2024

Since these are derived artifacts of this repo, and not intended to change, it does seem awkward to commit them here as though they're the canonical editable copy. Keeping them in a separate Git repo seems to make sense - maybe we should just add some documentation pointing to https://github.com/tp-m/wrapdb-v1-api-mirror/?

@tp-m
Copy link
Member Author

tp-m commented Nov 4, 2024

Since these are derived artifacts of this repo, and not intended to change, it does seem awkward to commit them here as though they're the canonical editable copy. Keeping them in a separate Git repo seems to make sense - maybe we should just add some documentation pointing to https://github.com/tp-m/wrapdb-v1-api-mirror/?

Sure I can do that, just thought we might want to have everything together in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapdb.mesonbuild.com v1 API support
3 participants