Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fftw3: Add new package #1503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antoniovazquezblanco
Copy link
Contributor

No description provided.

@antoniovazquezblanco
Copy link
Contributor Author

Temporarely patching CMake in the wrap until upstream fixes Clang build...

@@ -36,6 +36,9 @@
'extract.mk',
'rewrite.mk',
],
'fftw3': [
'CMakeLists.txt',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this is a review red flag and has to come with extremely good rationale.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix what fftw devels have just efficiently merged in FFTW/fftw3#354 but will probably take a long long time to get released. It fixes VS clang-cl builds.

source_hash = 56c932549852cddcfafdab3820b0200c7742675be92179e59e6215b340e26467
patch_directory = fftw3
method = cmake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use cmake, the wrapdb is for native meson builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatelly, fftw uses magic to generate (yes, you heard it right) and build their code. I understand the "meson only" build policy but I will not be able to provide meson build system support in a reasonable amount of time. I will mark this PR as a draft and will update my contribution when I find time to tackle the bigger job...

Thank you!

@antoniovazquezblanco antoniovazquezblanco marked this pull request as draft May 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants