Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intl & fr/en/it/de lngs #326

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SebFox2011
Copy link

I have introduce fr, en , it, and de language in the web meshtastic application.
It now use langage detector to display the right langage.

More trads to come...

Thanks for reviewing my mr :)

@Hunter275 Hunter275 added enhancement New feature or request help wanted Extra attention is needed major change This is a major change labels Oct 31, 2024
@Hunter275 Hunter275 changed the title [chore] [sebfox] add intl & fr/en/it/de lngs [Enhacement]: add intl & fr/en/it/de lngs Oct 31, 2024
@Hunter275 Hunter275 changed the title [Enhacement]: add intl & fr/en/it/de lngs Add intl & fr/en/it/de lngs Oct 31, 2024
.vscode/settings.json Outdated Show resolved Hide resolved
@fifieldt
Copy link
Collaborator

Thank you for putting in such a huge effort, and thank you for being patient in waiting for review :)

This looks good, aside from those two inadvertent file inclusions.

However, I think we need to check how this might affect the embedded web servers on hardware devices. The extra strings take up a bit of space, so we need to make sure there is space for that :)

@SebFox2011 SebFox2011 force-pushed the chore/add-internationnalisation branch from 8e71e73 to d290541 Compare November 10, 2024 17:36
@SebFox2011 SebFox2011 force-pushed the chore/add-internationnalisation branch from b1f51e4 to cef2f7a Compare November 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed major change This is a major change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants