-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intl & fr/en/it/de lngs #326
Open
SebFox2011
wants to merge
5
commits into
meshtastic:master
Choose a base branch
from
SebFox2011:chore/add-internationnalisation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add intl & fr/en/it/de lngs #326
SebFox2011
wants to merge
5
commits into
meshtastic:master
from
SebFox2011:chore/add-internationnalisation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunter275
added
enhancement
New feature or request
help wanted
Extra attention is needed
major change
This is a major change
labels
Oct 31, 2024
Hunter275
changed the title
[chore] [sebfox] add intl & fr/en/it/de lngs
[Enhacement]: add intl & fr/en/it/de lngs
Oct 31, 2024
Hunter275
changed the title
[Enhacement]: add intl & fr/en/it/de lngs
Add intl & fr/en/it/de lngs
Oct 31, 2024
fifieldt
reviewed
Nov 10, 2024
fifieldt
reviewed
Nov 10, 2024
Thank you for putting in such a huge effort, and thank you for being patient in waiting for review :) This looks good, aside from those two inadvertent file inclusions. However, I think we need to check how this might affect the embedded web servers on hardware devices. The extra strings take up a bit of space, so we need to make sure there is space for that :) |
SebFox2011
force-pushed
the
chore/add-internationnalisation
branch
from
November 10, 2024 17:36
8e71e73
to
d290541
Compare
SebFox2011
force-pushed
the
chore/add-internationnalisation
branch
from
November 25, 2024 07:53
b1f51e4
to
cef2f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
help wanted
Extra attention is needed
major change
This is a major change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduce fr, en , it, and de language in the web meshtastic application.
It now use langage detector to display the right langage.
More trads to come...
Thanks for reviewing my mr :)