Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requesting different telemetry types #687

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

ianmcorvidae
Copy link
Contributor

This allows passing an argument along with --request-telemetry. The default, without passing an argument, will be the current behavior, requesting device telemetry, also possible with --request-telemetry device. Other types can be requested with relevant arguments (environment, air_quality or airquality, or power)

Fixes #596

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (0573112) to head (78b92ce).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/mesh_interface.py 0.00% 26 Missing ⚠️
meshtastic/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
- Coverage   60.81%   60.68%   -0.13%     
==========================================
  Files          24       24              
  Lines        3762     3770       +8     
==========================================
  Hits         2288     2288              
- Misses       1474     1482       +8     
Flag Coverage Δ
unittests 60.68% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 3eabaf9 into meshtastic:master Oct 14, 2024
9 of 11 checks passed
@ianmcorvidae ianmcorvidae deleted the telemetry-types branch October 14, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: --request-environmental
1 participant