Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5 #657

Merged
merged 30 commits into from
Sep 11, 2024
Merged

2.5 #657

merged 30 commits into from
Sep 11, 2024

Conversation

ianmcorvidae
Copy link
Contributor

(opening this as a draft PR so that CI runs against the branch)

@ianmcorvidae ianmcorvidae linked an issue Aug 25, 2024 that may be closed by this pull request
6 tasks
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 28.40909% with 63 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (33a13f7) to head (ef6db0e).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/node.py 31.91% 32 Missing ⚠️
meshtastic/mesh_interface.py 25.00% 27 Missing ⚠️
meshtastic/__init__.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   61.48%   60.82%   -0.66%     
==========================================
  Files          24       24              
  Lines        3593     3658      +65     
==========================================
+ Hits         2209     2225      +16     
- Misses       1384     1433      +49     
Flag Coverage Δ
unittests 60.82% <28.40%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae marked this pull request as ready for review September 11, 2024 16:19
@ianmcorvidae ianmcorvidae merged commit ef6db0e into master Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.5 updates
4 participants