Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_direct radio option #631

Closed
wants to merge 1 commit into from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Dec 5, 2024

What does this PR do?

This allows to support a new option which I am using to test meshing when nodes are meters apart.

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

@thebentern
Copy link
Contributor

Since this is not something generally useful, you probably just need to keep this change in your local clone of protos.

@Jorropo
Copy link
Contributor Author

Jorropo commented Dec 5, 2024

I actually just pushed meshtastic/firmware#5511 after rewriting the code to use the newer relayer last byte id which is actually the thing I want to test.
I would usually not care about merging in protos for stuff like this given this is firmware's private config API except the fact it's how you configure the firmware and I want that feature in firmware ✨.

@GUVWAF
Copy link
Member

GUVWAF commented Dec 5, 2024

In meshtastic/firmware#5511 you're not checking the relay_node byte (which is not yet in use), but the last byte of the original transmitter (from).

Also, I don't really see the use of this outside of testing the mesh protocol, which I find much easier to do in simulation.

@thebentern thebentern closed this Dec 5, 2024
@Jorropo
Copy link
Contributor Author

Jorropo commented Dec 5, 2024

In meshtastic/firmware#5511 you're not checking the relay_node byte (which is not yet in use), but the last byte of the original transmitter (from).

🤦 meant relay node.

Also, I don't really see the use of this outside of testing the mesh protocol, which I find much easier to do in simulation.

¯\_(ツ)_/¯ ok

@Jorropo Jorropo deleted the ignore_incoming branch December 5, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants