Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Admin session_passkey to prevent replay of admin packets #558

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Adds Admin session_passkey to prevent replay of admin packets #558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc18854
Adds Admin session_passkey to prevent replay of admin packets
jp-bennett Aug 15, 2024
e765392
Update comment on admin_passkey
jp-bennett Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions meshtastic/admin.options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
*AdminMessage.payload_variant anonymous_oneof:true

*AdminMessage.session_passkey max_size:8

*AdminMessage.set_canned_message_module_messages max_size:201
*AdminMessage.get_canned_message_module_messages_response max_size:201
*AdminMessage.delete_file_request max_size:201
Expand Down
8 changes: 8 additions & 0 deletions meshtastic/admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ option swift_prefix = "";
* (Prior to 1.2 these operations were done via special ToRadio operations)
*/
message AdminMessage {

/*
* The node generates this key and sends it with any get_x_response packets.
* The client MUST include the same key with any set_x commands. Key expires after 120 seconds.
* Prevents replay attacks for admin messages.
*/
bytes session_passkey = 101;

/*
* TODO: REPLACE
*/
Expand Down