Extend Length of Source and Destination Node IDs Logged #5492
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a project to collect metrics from the mesh in our area. I currently have it functioning by maintaining a constant connection to a node via the serial interface and utilizing the Python libraries to extract the relevant information which works, but is not very efficient.
While transitioning this functionality to use syslog as it is lighter and creates the possibility to collect data from multiple nodes, I noticed that the syslog output, specifically for the
Lora RXlines, do not include the full source and destination Node IDs.I was unable to find any record of why these fields were truncated, so this PR attempts to extend them to their full length.
Previous Example
Lora RX (id=0x3d820dc9 fr=0x1b to=0x9a, WantAck=0, HopLim=3 Ch=0x8 encrypted rxSNR=-1 rxRSSI=-110 hopStart=3)Example with PR Applied
Lora RX (id=0x3d820dc9 fr=0xc0065b1b to=0xa6e7499a, WantAck=0, HopLim=2 Ch=0x8 encrypted rxSNR=5.5 rxRSSI=-71 hopStart=3)