Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP2040: Update core; add mDNS support #5355

Merged
merged 7 commits into from
Nov 16, 2024
Merged

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Nov 14, 2024

Updated the core, hopefully to fix potential FreeRTOS issues.
It also includes a new SimpleMDNS library that does work with FreeRTOS. Added a "meshtastic" service as there is no HTTP/HTTPS service, which the Android app now also looks for: meshtastic/Meshtastic-Android#1401. Tested this and it indeed finds the IP address now.

Lastly, added the -g option to link the source files for debugging.

Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that it only affects rpi, changes seem fine.

@fifieldt fifieldt merged commit 9545a10 into meshtastic:master Nov 16, 2024
46 of 47 checks passed
@GUVWAF GUVWAF deleted the rp2xx0Update branch November 17, 2024 16:16
@broglep
Copy link
Contributor

broglep commented Dec 4, 2024

Great to see MDNS support for the actual meshtastic tcp port, wanted to suggest that as well.
Is there any particular reason why not always announcing MDNS.addService("meshtastic", "tcp", 4403);, instead just for ARCH_RP2040 ?

@GUVWAF
Copy link
Member Author

GUVWAF commented Dec 4, 2024

Good question, it seemed a bit redundant to me, but it would indeed be more correct.

fifieldt pushed a commit to nebman/meshtastic-firmware that referenced this pull request Dec 14, 2024
* Update arduino-pico core

* RP2040: Add mDNS support

* SimpleMDNS `begin` now returns a bool

* Add `-g` option to `debug_build_flags` to link files for gdb

* RAK11310 needs old platform as well

* Change defines to specific architecture

* Core version 4.2.1 is out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants