Switch to actually maintained thingsboard pubsubclient #5204
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not work out of the box. Marking as draft :-( |
|
I read the background and it does look like this is the one to move to |
caveman99
approved these changes
Nov 2, 2024
|
https://github.com/thingsboard/pubsubclient/releases/tag/v2.11.0 fixed an issue with sending the credentials in the initial connection. Maybe this works now? It passed all the unit tests from #5724 and seems to be working on my heltec-v3 with my local MQTT server. I'll send them a PR and see if we can make some of the methods virtual, for use in those tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MQTT library of choice is without a maintainer and hasn't been updated in 4 years. Pretty depressing thread:
knolleary/pubsubclient#1045
Thingsboard has taken up the most involved fork of this and seems to have already integrated some good changes, even as recent as 2 weeks ago.