Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text/plain intent to send message #1389

Merged
merged 9 commits into from
Nov 30, 2024

Conversation

remi-espie
Copy link
Contributor

This PR adds a text/plain intent that allow user to share a piece of text to a Meshtastic node through the application.

This PR is currently a WIP. As of right now, only the intent was added.

The PR idea would be 2 fold:

  1. Add a way to easily share the text to a user-selected contact. For this, I thought of adding an optional txtToFill variable to the navigateToMessages function (or create a new function altogether). If not empty, this variable would autofill the text input of the selected contact.
  2. Create some kind of JSON struct that would be auto parsed, like
{
"contactKey": string,
"contactName": string,
"message": string,
"autosSend": bool
}

Upon completion, this PR would solve #1062 .

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jamesarich
Copy link
Contributor

I have been thinking about this in conjunction with direct reply from the notification - I'm hoping that these would use similar methods/intents to collect and deliver to the appropriate places.

@remi-espie
Copy link
Contributor Author

I decided to scale down this PR to solely be able to share a string of text, removing the json parser auto sending messages.
I had trouble with the auto sending of messages. It may be a part of a future PR.

This PR adds:

@remi-espie remi-espie marked this pull request as ready for review November 25, 2024 14:25
@andrekir andrekir linked an issue Nov 30, 2024 that may be closed by this pull request
@andrekir andrekir merged commit d76eac2 into meshtastic:master Nov 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Android client share feature.
4 participants