Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CRD to v1beta1 #551

Closed
wants to merge 3 commits into from
Closed

Upgrade CRD to v1beta1 #551

wants to merge 3 commits into from

Conversation

MUzairS15
Copy link

Description

This PR

  1. Upgrades kubebuilder.
  2. Upgrades v1alpha1 to v1beta1

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

MUzairS15 added 2 commits March 15, 2024 16:14
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
@MUzairS15 MUzairS15 changed the title Upgrade Upgrade CRD to v1beta1 Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.30%. Comparing base (68bae1e) to head (993a0b3).

Current head 993a0b3 differs from pull request most recent head 92ac3eb

Please upload reports for the commit 92ac3eb to get more accurate results.

Files Patch % Lines
controllers/broker_controller.go 75.00% 1 Missing ⚠️
controllers/meshsync_controller.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files           9        9           
  Lines         514      514           
=======================================
  Hits          274      274           
  Misses        221      221           
  Partials       19       19           
Flag Coverage Δ
unittests 53.30% <86.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some big changes here, @MUzairS15 💪

Copy link

stale bot commented Jun 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 20, 2024
Copy link

stale bot commented Jul 2, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Jul 2, 2024
@MUzairS15
Copy link
Author

Lets keep it closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants