Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update components & models to v1beta1 schema definitions #158

Closed
wants to merge 2 commits into from

Conversation

code-sleuth
Copy link

@code-sleuth code-sleuth commented May 20, 2024

Description
Update components & models to v1beta1 schema definitions

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-sleuth Thanks for volunteering 👍, but it might be that this is too much for your initial issues.
I will push some commits to this branch.

adapter/oam.go Outdated Show resolved Hide resolved
@MUzairS15
Copy link

https://docs.meshery.io/search/?q=adapter
There are few make targets that help you regenerate comps,
Use that to generate comps, start an adapter, and verify if comps are registered with the server.
To verify if comps are registered use Registry Browser in Meshery UI under Settings page.
OR use models API.
The endpoint listed here is what adapters use to register comps.

@MUzairS15
Copy link

Slide 42 inside Meshery Architecture deck captures the flow for adaptes.

@code-sleuth
Copy link
Author

code-sleuth commented May 29, 2024

@MUzairS15 There is no make target in this repo to build comps.

Signed-off-by: Ibrahim Mbaziira <[email protected]>
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-sleuth Were you able to generate and register these components?

@MUzairS15
Copy link

@code-sleuth any updates?

@code-sleuth
Copy link
Author

@MUzairS15 this is ready to ship

Copy link

stale bot commented Aug 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Aug 27, 2024
@code-sleuth
Copy link
Author

@MUzairS15 friendly ping

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Aug 27, 2024
@leecalcote
Copy link
Member

leecalcote commented Sep 11, 2024

@lekaf974, I wonder if you might be inclined to offer a review here.

@lekaf974
Copy link

Not being a lot involve in meshkit components until now but a good opportunity to learn so I'll take a look after make some research

Copy link

stale bot commented Oct 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 29, 2024
Copy link

stale bot commented Nov 9, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants