Merge pull request #137 from meshery/feat/bumpgo

Bump go version and remove no useful tracing code

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: Default Meshery Adapter Library CI
+name: CI
 
 on:
   push:

.golangci.yml

@@ -20,9 +20,8 @@ linters-settings:
     enabled: true
     check-shadowing: true
     tests: true
-  golint:
+  gofmt:
     enabled: true
-    min-confidence: 0.8
   unused:
     enabled: true
     check-exported: true
@@ -47,7 +46,7 @@ linters:
     - goconst
     - gocritic
     - govet
-    - golint
+    - gofmt
     - unused
     - cyclop
     - scopelint

Makefile

@@ -9,7 +9,6 @@ tidy:
 
 verify:
 	go mod verify
-	go vet ./...
 
 test:
 	go test --short ./... -race -coverprofile=coverage.txt -covermode=atomic

api/grpc/grpc.go

@@ -27,12 +27,9 @@ import (
 
 	"github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/recovery"
 	"github.com/layer5io/meshery-adapter-library/adapter"
-	"github.com/layer5io/meshery-adapter-library/api/tracing"
 	"github.com/layer5io/meshery-adapter-library/meshes"
 	"github.com/layer5io/meshkit/utils/events"
-	otelgrpc "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
-	"go.opentelemetry.io/otel"
-	sdktrace "go.opentelemetry.io/otel/sdk/trace"
+	"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/reflection"
 )
@@ -60,19 +57,13 @@ func panicHandler(r interface{}) error {
 }
 
 // Start starts grpc server.
-func Start(s *Service, _ tracing.Handler) error {
+func Start(s *Service) error {
 	address := fmt.Sprintf(":%s", s.Port)
 	listener, err := net.Listen("tcp", address)
 	if err != nil {
 		return ErrGrpcListener(err)
 	}
 
-	tp := sdktrace.NewTracerProvider(
-		sdktrace.WithSampler(sdktrace.AlwaysSample()),
-	)
-
-	otel.SetTracerProvider(tp)
-
 	server := grpc.NewServer(
 		grpc.ChainUnaryInterceptor(
 			otelgrpc.UnaryServerInterceptor(),

api/grpc/handlers.go

@@ -23,14 +23,6 @@ import (
 	"context"
 )
 
-// // CreateMeshInstance is the handler function for the method CreateMeshInstance.
-// func (s *Service) CreateMeshInstance(ctx context.Context, req *meshes.CreateMeshInstanceRequest) (*meshes.CreateMeshInstanceResponse, error) {
-// 	err := s.Handler.CreateInstance(&s.Channel)
-// 	if err != nil {
-// 		return nil, err
-// 	}
-// 	return &meshes.CreateMeshInstanceResponse{}, nil
-// }
 
 // MeshName is the handler function for the method MeshName.
 func (s *Service) MeshName(ctx context.Context, req *meshes.MeshNameRequest) (*meshes.MeshNameResponse, error) {