Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monge-Ampere zoom plot and tangling exercise #65

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Conversation

jwallwork23
Copy link
Member

Closes #50. Partly addresses #19.

This PR adds a zoom plot to the first Monge-Ampere demo to show that the elements aren't tangled, as well as an exercise to check this with MeshTanglingChecker.

The PR also applies some minor refactoring to MeshTanglingChecker, as well as writing unit tests for it.

@jwallwork23 jwallwork23 added documentation Improvements or additions to documentation testing Extensions and improvements to the testing infrastructure PRIORITY We should address this ASAP refactor A suggested reworking of the code labels Apr 4, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Apr 4, 2024
@jwallwork23 jwallwork23 self-assigned this Apr 4, 2024
Copy link
Collaborator

@stephankramer stephankramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. All looks good

@jwallwork23 jwallwork23 merged commit c6b51c1 into main Apr 4, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 50_zoom branch April 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PRIORITY We should address this ASAP refactor A suggested reworking of the code testing Extensions and improvements to the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zoom plot for basic Monge-Ampere demo
2 participants