Extend MA mover to 3D and add demo #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
documentation
jwallwork23
requested changes
Apr 4, 2024
There was a problem hiding this comment.
This is amazing, @stephankramer! Good work figuring out the generalisation to 3D. It makes sense to me and removes some annoying special casing.
My requests are fairly minor.
div(tau) contracts with 2nd index of tau, so in the boundary term we need tau.n, not n.tau Now gives good results in sinatan3 demo.
jwallwork23
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #61
Includes demo intended to be between the MA1 and MA_helmholz demos.