Introduce Solver class
#239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acse-ej321 we very briefly discussed this on the meeting and @jwallwork23 is in principle in favour of this. If you are as well, maybe you could try this approach for your enriched mesh seq issue and see if that solves it? I think it should since the two are now separated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238.
TODO (open for discussion):
MeshSeq(e.g.solve_forward,solve_adjoint) and pass theMeshSeqto theSolverobject, instead of vice-versaSolverand its methods? MaybeModelwould be better and then renameget_initial_conditiontoinitial_condition, etc.?field_namesandfield_typestoSolverso that it's self-containedclass AdjointSolver(Solver)