-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyproject.toml
approach
#16
Conversation
Also dropped some "old" configuration files and "backup" versions of scripts. They are all under version control so multiple versions are unnecessary. |
@erizmr Please could you review that you are happy with the following?
The rest of the changes are just formatting and linting changes. |
I tried to put both @erizmr and @chunyang-w down as reviewers but it appears that you can only request one reviewer on a private repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Remove submodules and update installation process
Thanks @erizmr! |
Closes #15.
Closes #13.
The best practice for Python packaging these days is to use a
pyproject.toml
file rather thansetup.py
andrequirements.txt
files. This PR sets that up.The PR also sets up automatic linting and formatting and applies it across the codebase. (The vast majority of the changes are formatting changes.)
To review this, it is sufficient to check:
pyproject.toml
.github/workflows/test_warpmesh.yml