Skip to content

Commit

Permalink
update date in description and CRAN comments for next devel version
Browse files Browse the repository at this point in the history
  • Loading branch information
merliseclyde committed Dec 6, 2023
1 parent ddf7f09 commit 40c450a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: BAS
Version: 1.7.1.9000
Date: 2023-12-5
Date: 2023-12-6
Title: Bayesian Variable Selection and Model Averaging using Bayesian Adaptive Sampling
Authors@R: c(person("Merlise", "Clyde", email="[email protected]",
role=c("aut","cre", "cph"),
Expand Down
17 changes: 2 additions & 15 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
# Notes to CRAN

## ReSubmission reason
## Submission reason

Submission prior to Dec 14 required to maintain package on CRAN.
Status on CRAN check page under `Additional Issues` for `valgrind` showed warnings `Conditional jump or move depends on uninitialised value(s)`.

- Initialized vector `se` via `memset` and `disp = 1.0` in `fit_glm.c` (issue #72)

- Initialized variables in `hyp1f1.c` from `testthat` (issue #75)

- Removed models that have zero prior probability in `bas.lm` and `bas.glm` (issue #74)

- Fixed error in `bayesglm.fit` to check arguments `x` or `y` for correct type before calling C and added unit test (issue #67)


## Test environments
Expand All @@ -30,11 +20,8 @@ Status on CRAN check page under `Additional Issues` for `valgrind` showed war
## R CMD check results for this submission

* Mmac, Windows, Ubunto, Debian
0 error | 0 warnings | 1 notes

Note: Days since last update: 6
0 error | 0 warnings | 0 notes

(resubmission requested by CRAN)

## Reverse Dependencies

Expand Down
2 changes: 2 additions & 0 deletions src/hypergeometric1F1.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ double loghyperg1F1_laplace(double a, double b, double x)
else mode = mode2;
// Rprintf("mode 1 %lf, mode %lf\n", mode1, mode2);
if (mode < 0) {
// # nocov start
mode = 0.0;
warning("1F1 Laplace approximation on boundary\n");
// # nocov end
}
else{
/* prec = a*mode*(1.0 - mode) + (1.0-mode)*(1.0 - mode)*b +
Expand Down

0 comments on commit 40c450a

Please sign in to comment.