Feature/configurable es modules #97
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2021 15:42
…t default module to CommonJS Update of file-loader and url-loader introduced the default module import is set to ES module, we set the config back to commonJS
…nfiguration to enable ESModules Add a option to make the switch between CommonJS and ES module type imports
kuddl
force-pushed
the
feature/ConfigurableESModules
branch
from
352e3da to
98a9647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
Right now, there is no option to configure the type of import ESModules or CommonJS.
Since file-loader 5.0 the default is set to "ESModules".
Therefore we needed a way to configure it back to CommonJS.
https://github.com/webpack-contrib/file-loader/releases/tag/v5.0.0
What is the new behavior?
You can configure, if you want to use CommonJS (default) or ESModules (with option set to true)
Does this PR introduce a breaking change?
Other information
Maybe we could write more test for this behaviour.
Right now, the tests, only check, if the option is set correctly
https://github.com/webpack-contrib/file-loader/releases/tag/v5.0.0