Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps with potential breaking changes #1111

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update deps with potential breaking changes #1111

merged 1 commit into from
Sep 9, 2024

Conversation

mcollina
Copy link
Collaborator

@mcollina mcollina commented Sep 9, 2024 •
edited
Loading

The changes to the loaders tests are due to mcollina/single-user-cache#30.

simoneb
simoneb approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what the linked PR fixes as there is no description, although I can see a switch from Object to Map, so I guess it's mostly a matter of uniqueness of keys. Anyhow, this LGTM

@mcollina mcollina merged commit fe4c63d into master Sep 9, 2024
14 checks passed
@mcollina mcollina deleted the update-deps branch September 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

@asciidisco asciidisco Awaiting requested review from asciidisco

@jonnydgreen jonnydgreen Awaiting requested review from jonnydgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @simoneb