Skip to content

Commit

Permalink
spelling and comments
Browse files Browse the repository at this point in the history
  • Loading branch information
huangjien committed Nov 20, 2023
1 parent e0685f8 commit a6adb80
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 1 addition & 3 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
"ghcr.io/devcontainers-contrib/features/curl-apt-get:1": {},
"ghcr.io/devcontainers-contrib/features/jfrog-cli-npm:1": {},
//"ghcr.io/devcontainers-contrib/features/jmeter-sdkman:2": {},
"ghcr.io/devcontainers/features/python:1": {}
},

Expand All @@ -27,6 +26,5 @@
"ghcr.io/devcontainers-contrib/features/curl-apt-get:1",
"ghcr.io/devcontainers-contrib/features/zsh-plugins",
"ghcr.io/devcontainers/features/docker-in-docker"
//"ghcr.io/jungaretti/features/make:1"
]
}
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ and other tools need in order to package, build and publish the collection::

### Use Dev Container

If you have install docker and VS Code on your machine, please add extension **Dev Containers** to VS Code, then you can use it to quickly setup your local development environment.
If you have installed docker and VS Code on your machine, please add extension **Dev Containers** to VS Code, then you can use it to quickly setup your local development environment.

1. Add **.env** file under foler **.devcontainer** , you can put environment variables in it, these env vars will appear in the docker container. And **.env** has been put in the .gitignore, so you can put secrets in it, it will not be merge to github repo. Content of it:
1. Add **.env** file under folder **.devcontainer** , you can put environment variables in it, these env vars will appear in the docker container. And **.env** has been put in the .gitignore, so you can put secrets in it, it will not be merge to github repo. Content of it:

```
ARTIFACTORY_URL=[artifactory url]
ARTIFACTORY_REPO=[repo contains software installer]
ARTIFACTORY_TOKEN=[token of artifactory]
LOCAL_PATH=/workspaces/spm-middleware
```
2. After dev container startup, you need to:
2. After the dev container startup, you need to:

a. install python packages
```
Expand Down

0 comments on commit a6adb80

Please sign in to comment.