Reorganize tests #1
Conversation
| @@ -1,4 +1,5 @@ | |||
| from openprocurement.relocation.core.tests.base import test_transfer_data | |||
| from openprocurement.api.tests.base import snitch | |||
| from .transfer_blanks import change_ownership | |||
|
|
||
| def check_permission(self, path, token): | ||
| pass | ||
| raise NotImplementedError('Please implement check_permission method') |
There was a problem hiding this comment.
тут вроді і без сказання повідомлення буде цілком зрозуміло.
|
|
||
|
|
||
| def simple_add_transfer(self): | ||
| data = {"access_token": "1234", |
There was a problem hiding this comment.
давай тут і для transfer_token впишемо більш правдоподібне значення - uuid4
|
|
||
|
|
||
| def get_transfer(self): | ||
| response = self.app.get('/transfers', status=405) |
| self.assertEqual(response.status, '200 OK') | ||
| self.assertNotIn('transfer', response.json['data']) | ||
| self.assertNotIn('transfer_token', response.json['data']) | ||
| if 'owner' in response.json['data']: |
There was a problem hiding this comment.
Маєш ідеї як позбутись цієї умови?
| # try to use already applied transfer | ||
| self.app.authorization = authorization | ||
| collection_path = '/'.join(self.request_path.split('/')[:-1]) | ||
| if hasattr(self, 'create_token'): |
|
|
||
|
|
||
| def change_ownership(self): | ||
| self.prepare_ownership_change() |
There was a problem hiding this comment.
Це могло б бути частиною setUp-у тесту?
| self.assertEqual(response.json['data']['owner'], self.first_owner) | ||
|
|
||
| # current owner can change his object !!! | ||
| response = self.check_permission(self.request_path, self.first_owner_token) |
There was a problem hiding this comment.
чому check_permission винесений окремо?
| # OwnershipChangeTestMixin | ||
|
|
||
|
|
||
| def change_ownership(self): |
There was a problem hiding this comment.
цей тест треба розбити на декілька.
якщо деякі з операцій (створення об'єкта для тестування) будуть повторюватись, це не страшно.
tarasvaskiv
force-pushed
the
a563836009868071_fix_update_tests
branch
2 times, most recently
from
42ff972
to
0e14f42
Compare
| from uuid import uuid4 | ||
| from copy import deepcopy | ||
|
|
||
| from openprocurement.relocation.core.tests.base import test_transfer_data |
There was a problem hiding this comment.
давай тут не імпортувати test_transfer_data, а оголосити її у відповідному класі, і у тестах тягнути як self.transfer_data
tarasvaskiv
force-pushed
the
a563836009868071_fix_update_tests
branch
2 times, most recently
from
1515714
to
9a966d7
Compare
tarasvaskiv
force-pushed
the
a563836009868071_fix_update_tests
branch
from
9a966d7
to
70de4da
Compare
No description provided.