Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually write bad points #68

Merged
merged 9 commits into from
May 27, 2024
Merged

Manually write bad points #68

merged 9 commits into from
May 27, 2024

Conversation

mepland
Copy link
Owner

@mepland mepland commented May 18, 2024 •
edited
Loading

Description

Create a script to manually write out a bad point. This is useful when a Bayesian optimization iteration is killed by the OS with an uncatchable SIGKILL. The user can then easily write out the point with BAD_TARGET and BAD_METRICS.

Type of Change

  • New feature: Non-breaking change which adds functionality
  • Docs: This change requires a documentation update

How Has This Been Tested?

Runs Locally.

Checklist

  • I have performed a self-review of my own code
  • I have run the pre-commit checks
  • The github tests action is passing
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation as required

mepland added 7 commits May 18, 2024 19:40
@mepland
Create a script to manually write out a bad point
894b8f3 
This is useful when a Bayesian optimization iteration is killed by the OS with an uncatchable SIGKILL.
The user can then easily write out the point with BAD_TARGET and BAD_METRICS.
@mepland
Add manual_bad_point model_name for those added via write_manual_bad_…
338f6a4 
…point

Exclude from mean and std time minutes_elapsed

Fix bug, BayesianOptimization needs hyperparam names in bounds
@mepland
combine lines
1c45977
@mepland
lint
04c6f66
@mepland
Add NHiTSModel bad point
f7e21b3
@mepland
lint
89a3101
@mepland
Another bad point for NHiTS
1c12924
@mepland mepland marked this pull request as ready for review May 19, 2024 19:48
mepland
mepland commented May 19, 2024
View reviewed changes
Copy link
Owner Author

@mepland mepland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

mepland
mepland commented May 27, 2024
View reviewed changes
Copy link
Owner Author

@mepland mepland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

@mepland mepland merged commit 0e0d0d5 into main May 27, 2024
4 checks passed
@mepland mepland deleted the manual_bad_point branch May 27, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mepland