Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plotting #34

Merged
merged 21 commits into from
Jan 1, 2024
Merged

Improve plotting #34

merged 21 commits into from
Jan 1, 2024

Conversation

mepland
Copy link
Owner

@mepland mepland commented Dec 31, 2023 •
edited
Loading

Description

  • Clean up plots, save files for README.md
  • Remove native prophet code, now that the darts wrapper has surpassed it
  • Add stats on DAQ up time
  • Standardize Path usage

Type of change

  • Bug fix: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds functionality
  • Breaking change: Fix or feature that would cause existing functionality to not work as expected
  • This change requires a documentation update

How Has This Been Tested?

Runs locally.

Checklist

  • I have performed a self-review of my own code
  • I have run the pre-commit checks
  • The github tests action is passing
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation as required

mepland added 21 commits December 30, 2023 19:04
@mepland
Import plotting last to avoid rcParams being reset
05e8290 
Check OBSERVED_PRESSURE_MIN value

Improve legend for plotly plots
@mepland
Update rcParams
4de0e90 
Add ref lines to plotly legend
@mepland
Update observed_pressure_min
24acc85
@mepland
Save plotly to html
3f91abd
@mepland
Work on plots
baf134d
@mepland
Change to outputs
5865d9a
@mepland
Add function to cleanly plot prophet figures
8d94c4d
@mepland
Clean up prophet plots
18f0516
@mepland
Add start_of_cron_heartbeat_monitoring
9a53e42
@mepland
Complete DAQ stats calc
212e64b
@mepland
Remove native prophet code, now that the darts wrapper has surpassed it.
00f7850
@mepland
Ignore mypy error
082ccc5 
Tried using:

if TYPE_CHECKING:
	assert isinstance(child, (mpl.lines.Line2D, mpl.collections.PolyCollection))

but mypy still could not find the set_lw attribute
@mepland
Clean up plot
6e52f5a
@mepland
Use pathlib.Path
aa70b16
@mepland
clean up paths, copy outputs
e59a47a
@mepland
Standardize Path usage
636492c
@mepland
Added PLOT_INLINE switch
cb6d011
@mepland
Don't raise, just continue
d13b672
@mepland
Do not copy metadata
0d1e5f2
@mepland
Saving ana outputs for README inclusion
d9bcc42
@mepland
ignore generated html, and all of media dir
92899fd
@mepland mepland marked this pull request as ready for review January 1, 2024 14:27
@mepland mepland merged commit 7aea8c8 into main Jan 1, 2024
4 checks passed
@mepland mepland deleted the improve_plotting branch January 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mepland