Skip to content

Commit

Permalink
Linting updates (#67)
Browse files Browse the repository at this point in the history
* Bump versions, pylint on python only, no ipynb

* match black version

* Clarify args
  • Loading branch information
mepland authored May 17, 2024
1 parent 56fb5a3 commit 7293794
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ jobs:
steps:
# Setup
- name: Check out source repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up poetry
uses: abatilo/actions-poetry@v2
with:
poetry-version: ${{ matrix.poetry-version }}

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'poetry'
Expand All @@ -59,6 +59,8 @@ jobs:
python:
- added|modified: '**.py'
- added|modified: '**.ipynb'
python_alone:
- added|modified: '**.py'
javascript:
- added|modified: '**.js'
html:
Expand Down Expand Up @@ -151,8 +153,8 @@ jobs:
run: poetry run mypy ${{ steps.filter.outputs.python_files }}

- name: pylint
if: steps.filter.outputs.python == 'true'
run: poetry run pylint ${{ steps.filter.outputs.python_files }}
if: steps.filter.outputs.python_alone == 'true'
run: poetry run pylint ${{ steps.filter.outputs.python_alone_files }}

- name: bandit
if: steps.filter.outputs.python == 'true'
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ repos:
hooks:
- id: blacken-docs
args: ['--line-length=100']
additional_dependencies: ['black==23.7.0']
additional_dependencies: ['black==24.3.0']

# flake8
- repo: https://github.com/pycqa/flake8
Expand Down Expand Up @@ -402,7 +402,7 @@ repos:
#### git
# don't commit to main
- id: no-commit-to-branch
args: ['-b main']
args: ['--branch', 'main']
# checks for files that contain merge conflict strings
- id: check-merge-conflict
args: ['--assume-in-merge']
Expand Down

0 comments on commit 7293794

Please sign in to comment.