[WTF-1882] Add support for reference sets(beta) to the typings generator #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alihcsumer
force-pushed
the
wtf-1882-support-reference-sets-for-linked-attribute-props
branch
from
2936d4f
to
6821de6
Compare
weirdwater
approved these changes
Jun 25, 2024
legio-vi-ferrata
approved these changes
Jun 25, 2024
legio-vi-ferrata
deleted the
wtf-1882-support-reference-sets-for-linked-attribute-props
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅ ❌This PR contains
What is the purpose of this PR?
Add support to the typings generator to be able to specify the association types allowed in attribute properties. Since the feature is still in beta, we are omitting it from the changelog for now.
...
Relevant changes
Depending on the configuration of the association types, the typings generator will now emit:
A client prop of (union) type ListAtrributeValue and/or ListAttributeListValue if the attribute property has a data source. A client prop of (union) type EditableValue and/or EditableListValue if not.
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required