[WTF-1735]: Fix PWT resolution/override versions #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersonRibeiro
approved these changes
Jan 9, 2024
legio-vi-ferrata
force-pushed
the
wtf-1735-fix-override-and-resolution-versions-in-migration-script
branch
from
8f5fe38
to
dab2102
Compare
jeffersonRibeiro
approved these changes
Jan 10, 2024
legio-vi-ferrata
force-pushed
the
wtf-1735-fix-override-and-resolution-versions-in-migration-script
branch
from
ee17948
to
aec3d3b
Compare
jeffersonRibeiro
approved these changes
Jan 15, 2024
alihcsumer
approved these changes
Jan 16, 2024
legio-vi-ferrata
deleted the
wtf-1735-fix-override-and-resolution-versions-in-migration-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the misaligned versions for
react,react-dom,react-nativepackages and their corresponding@typespackages during migration.Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
The migration script creates resolutions and overrides for three packages in an incorrect way. This PR fixes the issue by aligning the versions of those packages in the migration script.
Relevant changes
Some hard coded values are adjusted and extracted into constants to be the same everywhere they are relavant.
What should be covered while testing?
An example widget should be upgraded using the standard procedure. Another PR in docs repository is on the way to clearly state this standard procedure of upgrade.