-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WTF-1986] Generate types for metadata attribute properties #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdwater
force-pushed
the
wtf/flexible-filtering
branch
from
September 3, 2024 14:24
e828c88
to
c11f356
Compare
weirdwater
changed the title
[WTF-1920] Generate types for metadata attribute properties
[WTF-1923] Generate types for metadata attribute properties
Sep 3, 2024
weirdwater
force-pushed
the
wtf/flexible-filtering
branch
from
September 4, 2024 08:31
c11f356
to
2451050
Compare
weirdwater
changed the title
[WTF-1923] Generate types for metadata attribute properties
[WTF-1986] Generate types for metadata attribute properties
Sep 4, 2024
mlaponder
reviewed
Sep 5, 2024
packages/pluggable-widgets-tools/src/typings-generator/__tests__/inputs/metadata-attribute.ts
Outdated
Show resolved
Hide resolved
weirdwater
force-pushed
the
wtf/flexible-filtering
branch
from
September 9, 2024 10:03
32a079c
to
a248b5f
Compare
mlaponder
approved these changes
Sep 24, 2024
weirdwater
force-pushed
the
wtf/flexible-filtering
branch
from
September 24, 2024 12:57
2d578bf
to
13a5da1
Compare
weirdwater
force-pushed
the
wtf/flexible-filtering
branch
from
September 24, 2024 13:22
13a5da1
to
d884a76
Compare
ancajuravle
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description
)? ✅This PR contains
What is the purpose of this PR?
To lay the groundwork for offering cross-widget filtering and sorting of data sources. Enabling widget developers to build reusable and flexible filter controls.
Relevant changes
This PR introduces the
AttributeMetaDataProperty
type.What should be covered while testing?
That an attribute with the
isMetaData=true
flag results in aAttributeMetaData
type.