Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1162]: Upgrade android sdk version #715

Merged
merged 5 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,105 +1,161 @@
# Changelog

All notable changes to this template will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- We upgraded android SDK version to 33

## [7.0.3] - 2023-08-08

### Fixes

- We fixed distorted splash screen issue for android
Ahmad-Elsayed marked this conversation as resolved.
Show resolved Hide resolved

## [7.0.2] - 2023-08-01

### Fixes

- We fixed an issue with QR code scanner not working on iOS version of the custom dev app

## [6.2.25] - 2022-08-16

### Fixes

- Update ndk version to match AppCenter
- Update `react-native-permissions` library
- Removed `mendix.templateVersion` from package.json

## [6.2.24] - 2022-07-26

### Fixes

- We fixed an issue while uploading an iOS application to App Store
- We fixed crashes on Xiaomi smartphones
- We fixed an issue while building Android apps on AppCenter

## [6.2.23] - 2022-07-16

### Fixes

- We updated the minimum version of iOS to 14
- We remove QUERY_ALL_PACKAGES permission for Android apps
- We updated the version of react-native-vector-icons to 9.1.0
- We fixed an issue while building iOS apps in AppCenter

## [5.2.13] - 2022-06-15

### Fixes

- We fixed an issue with the date picker not being visible in dark mode.

## [6.2.22] - 2022-06-02

### Fixes

- We fixed an iOS build issue (#150964, #150934)

## [6.2.21] - 2022-06-01

### Fixes

- We fixed an iOS build issue for projects using Crashlytics.

## [6.2.20] - 2022-05-30

### Fixes

- We fixed an issue with logout action (Ticket #147429)

## [5.0.14] - 2022-05-17

### Fixes

- We fixed an issue with JCenter on Android and CocoaPods on iOS, which would fail to build (Ticket #148798 #148819 #148830 #148840)

## [5.1.19] - 2022-05-11

### Fixes

- We fixed an issue with JCenter on Android and CocoaPods on iOS, which would fail to build (Ticket #148798 #148819 #148830 #148840)

## [6.2.19] - 2022-05-11

### Fixes

- We fixed an issue with CocoaPods on iOS, which would fail to build

## [6.2.18] - 2022-05-11

### Fixes

- We fixed an issue with JCenter on Android, which would fail to build (Ticket #148798 #148819 #148830 #148840)

## [5.2.12] - 2022-05-11

### Fixes

- We fixed an issue with CocoaPods on iOS, which would fail to build

## [5.2.11] - 2022-05-10

### Fixes

- We fixed an issue with JCenter on Android, which would fail to build (Ticket #148798 #148819 #148830 #148840)

## [6.2.16] - 2022-03-29

### Fixes

- We fixed an issue with App Center CodePush on Android which would fail to install new OTA updates on devices. (Ticket 145335)

## [5.2.9] - 2022-03-29

### Improvements

- Native Template now supports full-screen Android video. The full-screen icon can be found at the top of the video when the show control's property is set to `true`. When the icon is pressed the video will continue working on an overlay modal. (Ticket 135581)

## [6.2.15] - 2022-03-23

### Fixes

- We fixed an issue where iOS custom developer apps incurred problems while building.

## [6.2.14] - 2022-03-17

### Fixes

- We fixed an issue where using react-native-async-storage made the iOS build fail due to duplicated symbols being generated.
- We fixed an issue where compiling an Android app for release would fail when building on a Windows machine.

## [6.2.13] - 2022-03-16 [YANKED]

### Fixes

## [6.2.12] - 2022-01-25

### Fixes

- We identified and fixed an issue that would stop the "Navigate To" action from launching Google Maps on Android OS version 11 and later.

## [5.2.8] - 2022-01-25

### Fixes

- We identified and fixed an issue that would stop the "Navigate To" action from launching Google Maps on Android OS version 11 and later.

## [6.2.11] - 2022-01-06

### Summary

- We identified and fixed a bug introduced with Native Template v6.2.9 and Mendix clients built with Mendix Studio Pro 9.8.0 or later and that support the new mobile encryption features. The iOS apps would wrongly clear the keychain values on each restart forcing users of the app to re-authenticate on each app restart.

*Rebuilding and releasing a new iOS app with this Native Template version will solve the issue.*
_Rebuilding and releasing a new iOS app with this Native Template version will solve the issue._

### Fixes

- OS apps should correctly persist the user session after each restart for clients built with Mendix Studio Pro 9.8.0 or later. (Ticket 138881)
1 change: 1 addition & 0 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
<uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
omnajjar marked this conversation as resolved.
Show resolved Hide resolved
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<!-- Required for scheduling local notifications -->
<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
Expand Down
6 changes: 3 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

buildscript {
ext {
buildToolsVersion = "31.0.0"
buildToolsVersion = "33.0.0"
minSdkVersion = 21
compileSdkVersion = 31
targetSdkVersion = 31
compileSdkVersion = 33
targetSdkVersion = 33
kotlin_version = "1.7.21"
excludeAppGlideModule = true
androidx_lifecycle_version = "2.3.1"
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{
"name": "native-template",
"version": "7.0.3",
"version": "7.0.4",
"private": true,
"scripts": {
"postinstall": "node patches/apply-patches.js && jetify",
"configure": "native-mobile-toolkit configure --config-path='./config.json' --verbose"
},
"dependencies": {
"@mendix/native": "~2.0.1",
"@mendix/react-native-sqlite-storage": "5.1.3",
"@react-native-community/async-storage": "1.12.1",
"@react-native-community/cameraroll": "4.0.1",
"@react-native-community/datetimepicker": "3.0.3",
Expand All @@ -22,13 +23,12 @@
"react-native-fast-image": "8.3.2",
"react-native-gesture-handler": "1.10.3",
"react-native-image-picker": "5.0.1",
"react-native-permissions": "3.3.1",
"react-native-localize": "1.4.2",
"react-native-permissions": "3.3.1",
"react-native-push-notification": "8.1.1",
"react-native-reanimated": "1.13.1",
"react-native-safe-area-context": "3.1.8",
"react-native-splash-screen": "3.2.0",
"@mendix/react-native-sqlite-storage": "5.1.3",
"react-native-svg": "12.1.0",
"react-native-vector-icons": "9.2.0",
"react-native-video": "5.2.1"
Expand Down
38 changes: 37 additions & 1 deletion patches/@react-native-community+cameraroll+4.0.1.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
diff --git a/node_modules/@react-native-community/cameraroll/android/gradle.properties b/node_modules/@react-native-community/cameraroll/android/gradle.properties
index 0bec1b5..a3dbe4e 100644
--- a/node_modules/@react-native-community/cameraroll/android/gradle.properties
+++ b/node_modules/@react-native-community/cameraroll/android/gradle.properties
@@ -1,4 +1,4 @@
-ReactNativeCameraRoll_compileSdkVersion=28
+ReactNativeCameraRoll_compileSdkVersion=33
Ahmad-Elsayed marked this conversation as resolved.
Show resolved Hide resolved
ReactNativeCameraRoll_buildToolsVersion=28.0.3
ReactNativeCameraRoll_targetSdkVersion=27
ReactNativeCameraRoll_minSdkVersion=16
diff --git a/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/CameraRollModule.java b/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/CameraRollModule.java
index b13e570..b681c45 100644
index b13e570..bfe46b2 100644
--- a/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/CameraRollModule.java
+++ b/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/CameraRollModule.java
@@ -9,6 +9,7 @@ package com.reactnativecommunity.cameraroll;
Expand Down Expand Up @@ -159,6 +169,32 @@ index b13e570..b681c45 100644
null,
new MediaScannerConnection.OnScanCompletedListener() {
@Override
@@ -633,7 +666,11 @@ public class CameraRollModule extends ReactContextBaseJavaModule {
+ photoUri.toString(),
e);
}
- retriever.release();
+ try {
+ retriever.release();
+ } catch (IOException e) {
+ // Do nothing. We can't handle this, and this is usually a system problem
+ }
}

if (photoDescriptor != null) {
@@ -699,7 +736,12 @@ public class CameraRollModule extends ReactContextBaseJavaModule {
+ photoUri.toString(),
e);
}
+
+ try {
retriever.release();
+ } catch (IOException e) {
+ // Do nothing. We can't handle this, and this is usually a system problem
+ }
} else {
BitmapFactory.Options options = new BitmapFactory.Options();
// Set inJustDecodeBounds to true so we don't actually load the Bitmap, but only get its
diff --git a/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/Utils.java b/node_modules/@react-native-community/cameraroll/android/src/main/java/com/reactnativecommunity/cameraroll/Utils.java
new file mode 100644
index 0000000..880802c
Expand Down
Loading