Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling on hover demo user switcher #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brambrink
Copy link

We felt that the hover state of the Demo User Switcher looked slightly out of place right now. This MR adds styling for the hover state.

Previous hover style:
Screenshot 2023-10-20 at 13 22 55

Current hover style:
Screenshot 2023-10-20 at 13 22 21

No hover style:
Screenshot 2023-10-20 at 13 22 10

@Catoledo84
Copy link

Hi there :) thank you very much for your idea

I am Ana, the designer currently working closely on Atlas topics, nice to meet you :)

While i agree with you that the current hover is not that good, here are some thoughts about your proposal:

  • your new idea looks a bit difficult to identify visually, because i see that you used a blue, greenish color, that is almost imperceptible to identify on hover, while in my opnion this should be really clear for the user indeed.
  • we should maybe think more about the color, and also contrast ratio for accessibility maters

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants