Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas Core: Import App custom-variables before the module own variables #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

askii2
Copy link

@askii2 askii2 commented May 12, 2024

With this change, variables values set in theme/web/custom-variables.scss using the !default flag
would take precedence over the values in themesource/atlas_core/web/_variables.scss like the normal assignments.

Our use case

We use two UI Modules:

  1. Our Style System, created using the tutorial in the docs, which we use in all our projects.
  2. Branding modules for some of our clients, containing only their colors and logo images.

The 1st sets default values for the $brand- variables, which the 2nd overrides when imported first.
However when the 2nd module is not present, the values in the 1st are ignored because of the !default flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant