Mender helm v6.0.0 #343
Mender helm v6.0.0 #343
Conversation
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Roberto Giovanardi <[email protected]>
| @@ -88,9 +89,9 @@ spec: | |||
| - name: HAVE_MULTITENANT | |||
| value: {{ .Values.global.enterprise | quote }} | |||
| - name: MENDER_VERSION | |||
| value: {{ trimPrefix "mender-" .Values.global.image.tag | quote }} | |||
| value: {{ trimPrefix "v" .Chart.AppVersion | quote }} | |||
There was a problem hiding this comment.
Maybe using the mender.image.tag function? This way, when you override the image tag (using a different Mender Server version than the default appVersion) it is showed up correctly
| value: {{ trimPrefix "v" .Chart.AppVersion | quote }} | |
| value: {{ include "mender.image.tag" | quote }} |
There was a problem hiding this comment.
Hmm... I believe we need to think of something here. I believe this is used for resolving the client version, so maybe we should start using the actual client version here instead 🤔
There was a problem hiding this comment.
it looks like on hosted this is no longer required as we can rely on the versions.json for the downloads section and on prem will be pointed to the install script... I'll create a task to clean up the env vars in the gui image 👌
mender/CHANGELOG.md
Outdated
| * workflows-worker and workflows-server uses the same image | ||
| - docker.io/mendersoftware/workflows-worker -> docker.io/mendersoftware/workflows | ||
| - registry.mender.io/mendersoftware/workflows-enterprise-worker -> registry.mender.io/mender-server-enterprise/workflows | ||
| * **DEPRECATION** `global.image` value is now deprecated and scheduled for removal |
There was a problem hiding this comment.
Nice!
- TODO: update the docs.mender.io for the custom values override:
sed 'e/global/default/'
mender/CHANGELOG.md
Outdated
| * All default values for service level `image` values have been unset | ||
| * The image is resolved from `default.image` | ||
| * `tenantadm.certs.key` is no longer required. | ||
| * Autogenerate missing required secrets. |
There was a problem hiding this comment.
🎉
- TODO: in the installation docs, remove the openssl key creation commands.
| @@ -1,3 +0,0 @@ | |||
| {{- define "mender.enterprisePullSecret" }} | |||
There was a problem hiding this comment.
Without the mender.enterprisePullSecret defined, you cannot populate the docker-registry and the docker-registry-prerelease secrets, which are used if if and .dot.Values.global.image .dot.Values.global.image.username
| @@ -138,7 +134,7 @@ spec: | |||
| {{- end }} | |||
|
|
|||
|
|
|||
| {{- if .dot.Values.global.image.username }} | |||
| {{- if and .dot.Values.global.image .dot.Values.global.image.username }} | |||
There was a problem hiding this comment.
So here you want to create the secret by hand by default, right? Since the global.image in the values.yaml file has been removed by default.. Maybe it worth mentioning about this change in the changelog
| private.pem: {{ .Values.device_auth.certs.key | b64enc }} | ||
| {{- else }} | ||
| private.pem: {{ genPrivateKey "ed25519" | b64enc }} |
|
After testing it for open-source, I was able to find several issues which I've for now kept in separate commit. I will |
With release-please and git cliff, the CHANGELOG.md and the releases are automated Ticket: MC-7582 Signed-off-by: Roberto Giovanardi <[email protected]>
|
This one's now ready for another round of review. I fixed a few things here and there after testing it using open-source and enterprise configurations/image references. |
There was a problem hiding this comment.
LGTM 👍
Of course, I cannot test it properly because the Mender v4.0.0 has not been published yet.
Out of scope, but since we're in a breaking release, could we also switch api_gateway.env.SSL=false ? Otherwise it won't work. See: https://northerntech.atlassian.net/browse/MEN-7260
BREAKING CHANGE: See CHANGELOG.md Signed-off-by: Alf-Rune Siqveland <[email protected]>
Starting with Mender server v4.0.0 the secret is no longer in used. The secret is not created/mounted to the service unless explicitly specified. Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Roberto Giovanardi <[email protected]> (cherry picked from commit 2bc8bf6) Signed-off-by: Alf-Rune Siqveland <[email protected]>
Changelog: Title Ticket: None Signed-off-by: Alf-Rune Siqveland <[email protected]>
alfrunes
force-pushed
the
v6.0.0-lesser
branch
from
f82d213
to
fd7676d
Compare
|
Merging these commits will result in the following changelog entries: Changelogsmender-helm (v6.0.0-lesser)New changes in mender-helm since master: Bug Fixes
|
alfrunes
changed the title
Thanks for reminding me, I forgot about this one. I cherry-picked it from #170 and amended the changelogs. |
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
Signed-off-by: Alf-Rune Siqveland <[email protected]>
…lease Release please CHANGELOG automation
You can choose to not to set either httpPort or httpsPort in the api_gateway, to prevent upload timeout with the Mender Cli, as reported by customers. Ticket: MEN-7595 Signed-off-by: Roberto Giovanardi <[email protected]>
With release-please and git cliff, the CHANGELOG.md and the releases are automated Ticket: MC-7582 Signed-off-by: Roberto Giovanardi <[email protected]>
Added Horizontal Pod Autoscaler resource to the gui container, to scale it automatically when the service experiences more load. Ticket: MC-7600 Signed-off-by: Roberto Giovanardi <[email protected]>
With the --unreleased flag, only the last release were added to the CHANGELOG.md, so the old history would have been lost. With this change, we'll just prepend the new git cliff release. Signed-off-by: Roberto Giovanardi <[email protected]>
We tried the --prepend option, that seems not working well, so getting back to the full changelog generation option from the entire git history Signed-off-by: Roberto Giovanardi <[email protected]>
Signed-off-by: Roberto Giovanardi <[email protected]>
This could happen in pipeline with cached jobs Signed-off-by: Roberto Giovanardi <[email protected]>
In some conditions the upstream pr branch could diverge from the local branch. With this fix it should rebase the upstream changes locally Signed-off-by: Roberto Giovanardi <[email protected]>
We don't care if the github remote is already existing, so we add a || true to carry on in case. Signed-off-by: Roberto Giovanardi <[email protected]>
To avoid race condition, using an unique remote github repository name and clean it up when everything is done. Signed-off-by: Roberto Giovanardi <[email protected]>
Not using && and using dashes instead, to better debug script issues Signed-off-by: Roberto Giovanardi <[email protected]>
Force the remote pr branch into the local one Signed-off-by: Roberto Giovanardi <[email protected]>
You can choose to not to set either httpPort or httpsPort in the api_gateway, to prevent upload timeout with the Mender Cli, as reported by customers. Ticket: MEN-7595 Signed-off-by: Roberto Giovanardi <[email protected]>
Signed-off-by: mender-test-bot <[email protected]>
BREAKING CHANGE: See CHANGELOG.md Signed-off-by: Alf-Rune Siqveland <[email protected]>
Starting with Mender server v4.0.0 the secret is no longer in used. The secret is not created/mounted to the service unless explicitly specified. Signed-off-by: Alf-Rune Siqveland <[email protected]>
Git cliff rewrites the changelog with the new format starting from this release, so let's start from a brand new files and move the old changelogs pre-v6 to a dedicated file. Signed-off-by: Roberto Giovanardi <[email protected]>
To ease the Mender Server onboarding for Open source users. If you want to use an external provided MongoDB, make sure to disable it. Signed-off-by: Roberto Giovanardi <[email protected]>
To ease the Mender Server onboarding for Open source users. If you want to use an external provided NATS, make sure to disable it. Signed-off-by: Roberto Giovanardi <[email protected]>
Redis is not used by default in the Open source version. Letting it enabled generates confusion, so let's disable it. Signed-off-by: Roberto Giovanardi <[email protected]>
The default install proposes the storage proxy feature enabled by default to a simplify onboarding experience Signed-off-by: Roberto Giovanardi <[email protected]>
With Seaweedfs, v6 breaking changes, and a dedicated upgrade document Signed-off-by: Roberto Giovanardi <[email protected]>
V6 suggestions and docs
Adapted scripts and snippets for testing the new helm chart v6 Signed-off-by: Roberto Giovanardi <[email protected]>
The playground option is needed to run an EKS cluster to manually play with, and a Changelog job is useless here. Signed-off-by: Roberto Giovanardi <[email protected]>
ci: adapt tests to the v6 chart
…e-fix ci: not running changelog job during playground
Always get the full git history, to generate a full changelog without missing commits. Changelog: None Ticket: None Signed-off-by: Roberto Giovanardi <[email protected]>
ci: get full git history to generate changelog
I tried to limit the changes to preserve as much backward compatibility as possible. However, this change cannot be done without some breaking changes (especially for workflows-worker).