Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tenantadm and iotmanager CronJobs #288

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oldgiova
Copy link
Contributor

@oldgiova oldgiova commented May 24, 2024

This is an Hosted only feature: cronjobs to maintain tenants

Ticket: MC-7433

Hosted Mender alignements:

  • cronjob-mender-tenantadm-suspend-expired.yaml originally contains two containers: this is splitted into two different CronJobs with the same schedules and the two different containers: this for reusing the _podtemplate
  • cronjob-mender-tenantadm-sync-tenants.yaml
  • cronjob-iot-manager-sync-devices.yaml

@oldgiova oldgiova requested review from alfrunes and removed request for alfrunes May 24, 2024 14:37
@oldgiova oldgiova changed the title Added tenantadm CronJobs WIP Added tenantadm CronJobs May 24, 2024
This is an Hosted only feature: cronjobs to maintain tenants

Ticket: MC-7433

Signed-off-by: Roberto Giovanardi <[email protected]>
Hosted only feature for IoT Manager Cronjobs

Ticket: MC-7433

Signed-off-by: Roberto Giovanardi <[email protected]>
@oldgiova oldgiova force-pushed the MC-7433-tenantadm-cronjobs branch from b655aa9 to 9c8f717 Compare May 24, 2024 15:14
@oldgiova oldgiova changed the title WIP Added tenantadm CronJobs Added tenantadm and iotmanager CronJobs May 24, 2024
@oldgiova oldgiova requested a review from alfrunes May 24, 2024 15:19
Copy link
Contributor

@alfrunes alfrunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about exposing internal tools to the public Helm chart. I believe the same also applies for other tools not present in this change. Could we maybe instead create a separate helm chart or kustomize environment for managing these resources?

@oldgiova
Copy link
Contributor Author

I'm not sure about exposing internal tools to the public Helm chart. I believe the same also applies for other tools not present in this change. Could we maybe instead create a separate helm chart or kustomize environment for managing these resources?

I wasn't sure either, but then I found this one: https://github.com/mendersoftware/mender-helm/blob/master/mender/templates/device-auth/cronjob.yaml :)

The issue is that the source of truth of the tenantadm image is now in the mender-helm repo... But let's talk about this:

  1. Separate helm chart: to inherit the same tenantadm version, that would be a subchart... But this subchart could not be private, so that would be a new public helm chart, so the principle it's the same of this PR, but it's an overcomplication
  2. kustomize: then we have to manually patch the tenantadm image, and I'm pretty sure we'll miss some update..
  3. New terraform modules: same as 2.

Maybe, we could use either kustomize or a new terraform module, and using the tenantadm:master image? If we really don't want to make these cronjobs public. But imho, since there's the device-auth cronjob already public, I see no value in moving these away from the source of truth (not a strong opinion btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants