fix(ce): Remove unused existingSecret condition for GITHUB_BOT_USER_ID

[ehumphrey-payments]

Removes the check for existingSecret on MEND_RNV_GITHUB_BOT_USER_ID, which was causing mendRnvGithubBotUserId to be an empty string if existingSecret was set.

Renovate may fail to start in some deployments since 8.0.0 without this fix.

Additionally, removed an extraneous or in the condition for BITBUCKET_USER (functionally no change).

Summary by CodeRabbit

• New Features

  • Simplified environment variable configuration for GitHub and Bitbucket integrations in the Mend Renovate application.

• Bug Fixes

  • Improved reliability in how the application retrieves configuration values related to GitHub and Bitbucket.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the deployment configuration of the Mend Renovate application within a Kubernetes environment. The primary changes involve the environment variables MEND_RNV_GITHUB_BOT_USER_ID and MEND_RNV_BITBUCKET_USER. The previous implementation included conditional checks that determined the setting of these environment variables based on the presence of specific values or existing secrets. The updated configuration simplifies this logic by removing the conditional checks, allowing these variables to be set directly based on specific values only.

No other aspects of the deployment configuration have been altered, including the deployment strategy, pod specifications, or other environment variables. The focus of the changes is strictly on the logic governing the two specified environment variables, which may influence how the application interacts with GitHub and Bitbucket integrations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.