Improves our unit test coverage #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the `mock` module as a test dependency. Note that Python3 supports `unittest.mock` in the standard library.
| 'configured correctly.'.format(config_file)) | ||
| sys.exit(1) | ||
| except yaml.scanner.ScannerError: | ||
| self.logger.error( |
There was a problem hiding this comment.
@joehakimrahme wondering why this is done manually here, can't the file loader check for syntax sanity depending on format?
There was a problem hiding this comment.
Not sure I understand the question.
If yaml.safe_load is given a file that's not a valid YAML it will throw a yaml.scanner.ScannerError exception. I just think it's best to catch it on the spot and exit the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more unit tests to increase our overall coverage of the script.
Introduces the
mockmodule as a test dependency.Note that Python3 supports
unittest.mockin the standard library.Some refactoring need to be done in
test_load_invalid_config_failureonce the PR #10 is merged (As far as I know Github doesn't support dependent PRs so I had to find a temporary solution).