Refactor RTMP namespace #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartkrak
approved these changes
Aug 7, 2024
lib/membrane_rtmp_plugin/utils.ex
Outdated
There was a problem hiding this comment.
This was used in boombox, so it will need an update.
mat-hek
reviewed
Aug 8, 2024
| @@ -1,10 +1,10 @@ | |||
| defmodule Membrane.RTMP.Source.ClientHandler do | |||
| defmodule Membrane.RTMP.Source.ClientHandlerForSource do | |||
There was a problem hiding this comment.
I understand it's to avoid confusion with the behaviour, but I'd leave it as is, just never alias it. Alternatively let's call it ClientHandlerImpl
There was a problem hiding this comment.
I'm up to the second option ;)
mat-hek
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RTMP.ServerintoRTMPServerparse_urlutils function to RTMPServerparse_urlso that it now support URLs without app and stream_keyRTMPServer.ClientHandlerandRTMPServer.ClientHandlerBehaviourSource.ClientHandlerintoSource.ClientHandlerForSource